Using 4.1 March 12th build.

SubDetailEntity is subtype of DetailEntity.

Trying to do a batch update on the subtype, this code

var filter = new RelationPredicateBucket(SubDetailFields.OrderId == 12345);
Adapter.UpdateEntitiesDirectly(new SubDetailEntity{ Field = false }, filter);

produces this SQL

UPDATE [SubDetail]
SET [Field] = @p1
WHERE  ((([Detail].[OrderId] = @p2)))

which fails with error

The multi-part identifier "Detail.OrderId" could not be bound.

because there is no JOIN with the supertype.

But when I filter on the PK of the subtype (and supertype)

var filter = new RelationPredicateBucket(SubDetailFields.Id == 54321);
Adapter.UpdateEntitiesDirectly(new SubDetailEntity{ Field = false }, filter);

then this SQL is generated

UPDATE [SubDetail]
SET [Field] = @p1
FROM   ( [Detail]
         LEFT JOIN [SubDetail]
             ON [Detail].[Id] = [SubDetail].[Id])
WHERE  ((([SubDetail].[Id] = @p2))) 

in which the FROM with JOIN is not really necessary in my opinion.

Is the OrderId field defined in the DetailEntity?

Walaa wrote:

Is the OrderId field defined in the DetailEntity?

Yes. OrderId is a column in DetailEntity. Field in SubDetailEntity.

Odd. We'll look into it.

Hmm, we have a couple of tests for this method, and I see we missed the scenario you're using. There are a couple of scenarios: update subtype or supertype field and no filter, update supertype field and subtype field, update subtype field and subtype filter, update subtype field and supertype filter. Although the system should automatically add the right joins based on the elements used in the statement, the tests we have missed your situation, namely update subtype field and supertype filter. We'll add that now and see whether it reproduces your problem.

Thanks.

Reproduced...

Code which should fix it is there but works on the wrong variable How stupid. Will fix it and attach a new build for you.

Otis wrote:

Code which should fix it is there but works on the wrong variable How stupid. Will fix it and attach a new build for you.

Great, but don't forget your lunch

See attached fix I attached both the .net 3.5 and .net 4.5 build

twaindev wrote:

Otis wrote:

Code which should fix it is there but works on the wrong variable How stupid. Will fix it and attach a new build for you.

Great, but don't forget your lunch

Good point Will grab one now Let me know if the fix fails in your situation (all tests pass here)

Otis wrote:

Let me know if the fix fails in your situation (all tests pass here)

The generated SQL now looks like this

UPDATE [SubDetaiL]
SET [Field] = @p1
FROM   ( [Detail]
         INNER JOIN [SubDetaiL]
             ON [Detail].[Id] = [SubDetaiL].[Id])
WHERE  ((([Detail].[OrderId] = @p2))) 

so it is ok now

Thanks